nerdcruft/libcruft-util
1
0
Fork 0
Code Issues Releases Activity

Clean up signed type conversions in parse dispatch

Browse Source
This commit is contained in:
Danny Robson 2013-08-05 16:39:40 +10:00
parent 00fe6c12e3
commit eb0f609f81
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
options.cpp
View File

@ -447,9 +447,9 @@ processor::parse_args (int argc, const char ** argv) {
for (auto &i: m_options) for (auto &i: m_options)
i->reset (); i->reset ();
const unsigned int FIRST_ARGUMENT = 1; const int FIRST_ARGUMENT = 1;
try { try {
for (size_t i = FIRST_ARGUMENT; i < sign_cast<unsigned> (argc); ++i) { for (int i = FIRST_ARGUMENT; i < argc; ++i) {
// An argument must begin with a dash, if not we've reached the // An argument must begin with a dash, if not we've reached the
// end of the argument lists or we have a parsing error. // end of the argument lists or we have a parsing error.
if (argv[i][0] != '-') if (argv[i][0] != '-')
@ -465,10 +465,10 @@ processor::parse_args (int argc, const char ** argv) {
if (argv[i][1] != '-') if (argv[i][1] != '-')
consumed = parse_short (i, argc, argv); consumed = parse_short (i, argc, argv);
else else
consumed = parse_long (i, argc, argv); consumed = parse_long (i, argc, argv);
assert (consumed >= 1); assert (consumed >= 1);
i += consumed - 1; i += sign_cast<int> (consumed - 1);
} }
} catch (runtime_error &x) { } catch (runtime_error &x) {
print_usage (); print_usage ();