From eb0f609f819aa60242bba3c5eebe3c366bcf6edb Mon Sep 17 00:00:00 2001
From: Danny Robson <danny@nerdcruft.net>
Date: Mon, 5 Aug 2013 16:39:40 +1000
Subject: [PATCH] Clean up signed type conversions in parse dispatch

---
 options.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/options.cpp b/options.cpp
index b2d81f3a..3cb3ec89 100644
--- a/options.cpp
+++ b/options.cpp
@@ -447,9 +447,9 @@ processor::parse_args (int argc, const char ** argv) {
     for (auto &i: m_options)
         i->reset ();
 
-    const unsigned int FIRST_ARGUMENT = 1;
+    const int FIRST_ARGUMENT = 1;
     try {
-        for (size_t i = FIRST_ARGUMENT; i < sign_cast<unsigned> (argc); ++i) {
+        for (int i = FIRST_ARGUMENT; i < argc; ++i) {
             // An argument must begin with a dash, if not we've reached the
             // end of the argument lists or we have a parsing error.
             if (argv[i][0] != '-')
@@ -465,10 +465,10 @@ processor::parse_args (int argc, const char ** argv) {
             if (argv[i][1] != '-') 
                 consumed = parse_short (i, argc, argv);
             else 
-                consumed =  parse_long (i, argc, argv);
+                consumed = parse_long (i, argc, argv);
 
             assert (consumed >= 1);
-            i += consumed - 1;
+            i += sign_cast<int> (consumed - 1);
         }
     } catch (runtime_error &x) {
         print_usage ();