From e7a76081e0f4c473df593f51af7882036a14a919 Mon Sep 17 00:00:00 2001
From: Danny Robson <danny@nerdcruft.net>
Date: Mon, 16 Apr 2018 15:54:08 +1000
Subject: [PATCH] point: don't directly iterate over data

---
 point.cpp | 26 +-------------------------
 point.hpp |  6 +++---
 2 files changed, 4 insertions(+), 28 deletions(-)

diff --git a/point.cpp b/point.cpp
index bbda9bc6..d4730efd 100644
--- a/point.cpp
+++ b/point.cpp
@@ -11,7 +11,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  *
- * Copyright 2011-2016 Danny Robson <danny@nerdcruft.net>
+ * Copyright 2011-2018 Danny Robson <danny@nerdcruft.net>
  */
 
 #include "point.hpp"
@@ -23,30 +23,6 @@
 using util::point;
 
 
-///////////////////////////////////////////////////////////////////////////////
-template <size_t S, typename T>
-util::vector<S,T>
-util::point<S,T>::to (point<S,T> rhs) const
-{
-    util::vector<S,T> out;
-    for (size_t i = 0; i < S; ++i)
-        out.data[i] = rhs.data[i] - this->data[i];
-    return out;
-}
-
-
-//-----------------------------------------------------------------------------
-template <size_t S, typename T>
-util::vector<S,T>
-util::point<S,T>::from (point<S,T> rhs) const
-{
-    util::vector<S,T> out;
-    for (size_t i = 0; i < S; ++i)
-        out.data[i] = this->data[i] - rhs.data[i];
-    return out;
-}
-
-
 ///////////////////////////////////////////////////////////////////////////////
 namespace util::debug  {
     template <size_t S, typename T>
diff --git a/point.hpp b/point.hpp
index d6568cdb..4967cb6f 100644
--- a/point.hpp
+++ b/point.hpp
@@ -11,7 +11,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  *
- * Copyright 2011-2016 Danny Robson <danny@nerdcruft.net>
+ * Copyright 2011-2018 Danny Robson <danny@nerdcruft.net>
  */
 
 #ifndef CRUFT_UTIL_POINT_HPP
@@ -34,8 +34,8 @@ namespace util {
     {
         using coord::base<S,T,point<S,T>>::base;
 
-        vector<S,T> to (point) const;
-        vector<S,T> from (point) const;
+        vector<S,T> to (point dst) const { return dst - *this; }
+        vector<S,T> from (point src) const { return *this - src; }
 
         /// expand point to use homogenous coordinates of a higher dimension.
         /// ie, fill with (0,..,0,1)