nerdcruft/libcruft-util
1
0
Fork 0
Code Issues Releases Activity

format: use const-ref over rval-ref for value params

Browse Source
This commit is contained in:
Danny Robson 2016-07-28 14:14:15 +10:00
parent b44e6b8cd7
commit b4640d64d8
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
format.ipp
View File

@ -856,7 +856,7 @@ namespace util { namespace format { namespace detail {
//------------------------------------------------------------------------ //------------------------------------------------------------------------
template <typename ValueT, typename ...Args, typename OutputT> template <typename ValueT, typename ...Args, typename OutputT>
OutputT OutputT
_render (OutputT os, const char *first, const char *last, ValueT val, Args&& ...args) _render (OutputT os, const char *first, const char *last, const ValueT &val, const Args &...args)
{ {
auto start = std::find (first, last, '%'); auto start = std::find (first, last, '%');
os = std::copy (first, start, os); os = std::copy (first, start, os);
@ -865,14 +865,14 @@ namespace util { namespace format { namespace detail {
specifier spec; specifier spec;
auto cursor = parse (start, last, spec); auto cursor = parse (start, last, spec);
return _render (write (os, spec, val), cursor, last, std::forward<Args> (args)...); return _render (write (os, spec, val), cursor, last, args...);
} }
//------------------------------------------------------------------------ //------------------------------------------------------------------------
template <typename ValueT, typename ...Args, typename OutputT, size_t N> template <typename ValueT, typename ...Args, typename OutputT, size_t N>
OutputT OutputT
render (OutputT os, const char (&fmt)[N], ValueT val, Args&& ...args) render (OutputT os, const char (&fmt)[N], const ValueT &val, const Args &...args)
{ {
if (N <= 1) if (N <= 1)
return os; return os;
@ -880,7 +880,7 @@ namespace util { namespace format { namespace detail {
const auto first = fmt; const auto first = fmt;
const auto last = fmt + N - 1; const auto last = fmt + N - 1;
return _render (os, first, last, val, std::forward<Args> (args)...); return _render (os, first, last, val, args...);
} }