nerdcruft/libcruft-util
1
0
Fork 0
Code Issues Releases Activity

string: fancy comparators should take only string_views

Browse Source 
This reduces complications dealing with implicit casts from things like
'std::string' which are fairly common.
This commit is contained in:
Danny Robson 2020-10-21 10:23:04 +10:00
parent 8111074a44
commit b0ac349f70
2 changed files with 2 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
string.hpp
View File

@ -302,10 +302,9 @@ namespace cruft::string::compare {
/// \tparam TransformV A character transform function /// \tparam TransformV A character transform function
template <char (*TransformV)(char) noexcept> template <char (*TransformV)(char) noexcept>
struct transform { struct transform {
template <typename ContainerT>
bool operator() ( bool operator() (
ContainerT const &a, std::string_view const &a,
ContainerT const &b std::string_view const &b
) const noexcept { ) const noexcept {
if (a.size () != b.size ()) if (a.size () != b.size ())
return false; return false;
@ -316,18 +315,6 @@ namespace cruft::string::compare {
return true; return true;
} }
template <
typename CharT,
typename = std::void_t<
typename std::char_traits<CharT>::char_type
>
>
bool operator() (CharT const *a, CharT const *b) const noexcept
{
return (*this) (std::string_view (a), std::string_view (b));
}
}; };
using lower = transform<ascii::try_lower>; using lower = transform<ascii::try_lower>;

9
test/string.cpp
View File

@ -210,15 +210,6 @@ void test_comparator_lower (cruft::TAP::logger &tap)
for (auto const &t: TESTS) { for (auto const &t: TESTS) {
tap.expect_eq (cmp (t.a, t.b), t.equal, "compare::lower, pointers, %!", t.message); tap.expect_eq (cmp (t.a, t.b), t.equal, "compare::lower, pointers, %!", t.message);
tap.expect_eq (
cmp (
cruft::view (t.a),
cruft::view (t.b)
),
t.equal,
"compare::lower, views, %!",
t.message
);
} }
} }