nerdcruft/libcruft-util
1
0
Fork 0
Code Issues Releases Activity

Store loop conditions before dispatching signal

Browse Source 
If we store the loop condition before executing the functor we have a
better chance of avoiding iterator invalidation from any trickery on the
subscriber side.
This commit is contained in:
Danny Robson 2011-09-16 22:57:25 +10:00
parent d024c588db
commit a3c602407f
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
signal.hpp
View File

@ -106,9 +106,14 @@ namespace util {
/// Execute all callbacks, ignoring the return parameters. Does not combine results. /// Execute all callbacks, ignoring the return parameters. Does not combine results.
void operator () (Args... tail) { void operator () (Args... tail) {
for (auto i = m_children.cbegin (); i != m_children.cend (); ) { auto i = m_children.cbegin ();
bool looping = m_children.cend () != i;
while (looping) {
// Increment before we execute so that the caller is able to deregister during execution. // Increment before we execute so that the caller is able to deregister during execution.
auto current = i++; auto current = i++;
looping = m_children.cend () != i;
(*current)(tail...); (*current)(tail...);
} }
} }