nerdcruft/libcruft-util
1
0
Fork 0
Code Issues Releases Activity

algo/sort: work around gcc lamba param aliasing bug

Browse Source
This commit is contained in:
Danny Robson 2017-05-18 18:38:23 +10:00
parent 1ad3e0bde0
commit 92727ff351
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
algo/sort.ipp
View File

@ -98,9 +98,17 @@ cruft::util::sort::soa (RandomIt key_first,
std::sort (std::begin (indices), std::sort (std::begin (indices),
std::end (indices), std::end (indices),
[&] (const auto &a, const auto &b) [&] (const auto &cruft_util_sort_soa_a, const auto &cruft_util_sort_soa_b)
{ {
return comp (key_first[a], key_first[b]); // GCC: we use the ridiculous parameter names to avoid a name aliasing
// bug/warning under gcc 6.3.0; if the client passes a comparator
// lambda that uses the same parameter names then a warning will be
// generated. given 'a' and 'b' aren't unlikely names we try to avoid
// them here.
return comp (
key_first[cruft_util_sort_soa_a],
key_first[cruft_util_sort_soa_b]
);
}); });
// convert from a sorted list of pointers to a mapping of pointers to // convert from a sorted list of pointers to a mapping of pointers to