nerdcruft/libcruft-util
1
0
Fork 0
Code Issues Releases Activity

prefer passing by reference over value

Browse Source
This commit is contained in:
Danny Robson 2018-07-24 15:46:28 +10:00
parent 946397e325
commit 799768641f
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
backtrace.hpp
View File

@ -32,8 +32,7 @@ namespace debug {
public: public:
backtrace (void); backtrace (void);
const decltype(m_frames)& frames(void) const const auto& frames(void) const { return m_frames; }
{ return m_frames; }
}; };
std::ostream& std::ostream&

2
backtrace_execinfo.cpp
View File

@ -72,7 +72,7 @@ addr2line (const void *addr)
/////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////
std::ostream& std::ostream&
debug::operator <<(std::ostream &os, const debug::backtrace &rhs) { debug::operator <<(std::ostream &os, const debug::backtrace &rhs) {
const auto frames = rhs.frames (); auto const &frames = rhs.frames ();
// We don't use the array form of unique_ptr as clang fails on ambigious constructors // We don't use the array form of unique_ptr as clang fails on ambigious constructors
typedef std::unique_ptr<char *, decltype(&std::free)> str_t; typedef std::unique_ptr<char *, decltype(&std::free)> str_t;

2
test/iterator.cpp
View File

@ -22,7 +22,7 @@ main (int, char**)
char c_char[] = { '\0', 'b', 'c' }; char c_char[] = { '\0', 'b', 'c' };
bool success = true; bool success = true;
for (auto [i, v, a, c]: util::izip (v_int, a_float, c_char)) { for (auto const &[i, v, a, c]: util::izip (v_int, a_float, c_char)) {
success = success && success = success &&
v_int[i] == v && v_int[i] == v &&
util::equal (a_float[i], a) && util::equal (a_float[i], a) &&