From 79409eb6fe81149e37a4d2ac8e126439bfece60e Mon Sep 17 00:00:00 2001
From: Danny Robson <danny@nerdcruft.net>
Date: Tue, 24 Jul 2018 15:49:11 +1000
Subject: [PATCH] avoid push_back in loops

Detected by clang-tidy.
---
 test/job/queue.cpp   | 12 +++++-------
 test/thread/flag.cpp |  9 +++++++--
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/test/job/queue.cpp b/test/job/queue.cpp
index a56e9ddf..eb1fae85 100644
--- a/test/job/queue.cpp
+++ b/test/job/queue.cpp
@@ -34,14 +34,12 @@ main (void)
         {
             util::job::queue q {std::thread::hardware_concurrency (), INNER};
             std::vector<util::job::queue::cookie> cookies;
-            for (int j = 0; j < INNER; ++j) {
-                cookies.push_back (
-                    q.submit (
-                        sleep_inc,
-                        std::ref (count)
-                    )
+            std::generate_n (std::back_inserter (cookies), INNER, [&] () {
+                return q.submit (
+                    sleep_inc,
+                    std::ref (count)
                 );
-            }
+            });
         }
 
         success = count == INNER && success;
diff --git a/test/thread/flag.cpp b/test/thread/flag.cpp
index ce6319f6..8264cbb7 100644
--- a/test/thread/flag.cpp
+++ b/test/thread/flag.cpp
@@ -60,8 +60,13 @@ main ()
         };
 
         std::vector<std::thread> workers;
-        for (int i = 0; i < parallelism; ++i)
-            workers.emplace_back (func, i);
+        std::generate_n (
+            std::back_inserter (workers),
+            parallelism,
+            [&, i = 0] () mutable
+        {
+               return std::thread { func, i++ };
+        });
 
         for (auto &t: workers)
             t.join ();