build: quiesce type conversion warnings

crypto/ice.cpp

@@ -23,7 +23,8 @@
 
 #include "./ice.hpp"
 
-#include "endian.hpp"
+#include "../endian.hpp"
+#include "../debug.hpp"
 
 #include <cstdint>
 
@@ -180,7 +181,7 @@ ice_sboxes_init (void)
                       ice_smod[j][row]
             ) << (24 - j * 8);
 
-            ice_sbox[j][i] = ice_perm32 (p);
+            ice_sbox[j][i] = ice_perm32 (static_cast<uint32_t>(p));
         }
     }
 }
@@ -394,6 +395,8 @@ ice::set (const uint64_t *_key_first, const uint64_t *_key_last)
     auto key = reinterpret_cast<const uint8_t*> (_key_first);
 
     if (m_rounds == 8) {
+        CHECK_EQ (_key_last - _key_first, 8 * 2 + 1);
+
         std::array<uint16_t,4> kb;
 
         for (unsigned i = 0; i < 4; i++)
@@ -404,6 +407,8 @@ ice::set (const uint64_t *_key_first, const uint64_t *_key_last)
     }
 
     for (unsigned i = 0; i < m_size; i++) {
+        CHECK_EQ ((unsigned)(_key_last - _key_first), m_size * 8u + 4u * 2u + 1u);
+
         std::array<uint16_t,4> kb;
 
         for (unsigned j = 0; j < 4; j++)

json/tree.cpp

@@ -388,6 +388,8 @@ json::tree::node::as_chars (void) const&
 
 ///////////////////////////////////////////////////////////////////////////////
 namespace json { namespace tree {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wuseless-cast"
     template <>
     bool node::as (void) const
     {
@@ -446,6 +448,7 @@ namespace json { namespace tree {
     {
         return static_cast<int64_t> (as_sint ());
     }
+#pragma GCC diagnostic pop
 } }
 
 

rand/lcg.cpp

@@ -19,6 +19,7 @@
 using util::rand::lcg;
 
 
+///////////////////////////////////////////////////////////////////////////////
 template <typename T>
 static constexpr
 bool is_coprime (T M, T C)