From 640b4aa6caff40b8731c22dfe062066dad5d5182 Mon Sep 17 00:00:00 2001 From: Danny Robson Date: Thu, 12 May 2016 17:45:29 +1000 Subject: [PATCH] build: fix switch/enum coverage warnings uncovered using clang's -Wswitch-enum --- hash/sha1.cpp | 4 ++-- uri.cpp.rl | 4 +++- version.cpp.rl | 13 ++++++------- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hash/sha1.cpp b/hash/sha1.cpp index 06bd1e1b..7ebfc980 100644 --- a/hash/sha1.cpp +++ b/hash/sha1.cpp @@ -40,9 +40,9 @@ operator<< (std::ostream &os, SHA1::state_t t) { switch (t) { case SHA1::READY: os << "READY"; return os; case SHA1::FINISHED: os << "FINISHED"; return os; - default: - unreachable (); } + + unreachable (); } diff --git a/uri.cpp.rl b/uri.cpp.rl index 555cbb36..a5f02f23 100644 --- a/uri.cpp.rl +++ b/uri.cpp.rl @@ -275,7 +275,9 @@ util::operator<< (std::ostream &os, util::uri::component c) case util::uri::QUERY: return os << "QUERY"; case util::uri::FRAGMENT: return os << "FRAGMENT"; - default: + case util::uri::NUM_COMPONENTS: unreachable (); } + + unreachable (); } diff --git a/version.cpp.rl b/version.cpp.rl index 13137425..bfee7223 100644 --- a/version.cpp.rl +++ b/version.cpp.rl @@ -199,14 +199,13 @@ namespace util { operator<< (std::ostream& os, const util::version::release_t r) { switch (r) { - case version::ALPHA: return os << 'a'; - case version::BETA: return os << 'b'; - case version::GAMMA: return os << 'g'; - case version::PRODUCTION: return os; - - default: - unreachable (); + case version::ALPHA: return os << 'a'; + case version::BETA: return os << 'b'; + case version::GAMMA: return os << 'g'; + case version::PRODUCTION: return os; } + + unreachable (); } }