build: fix warnings from -Wparentheses

bitwise.hpp

@@ -39,7 +39,7 @@ namespace util {
     constexpr T
     rotatel [[gnu::pure]] (const T value, std::size_t magnitude)
     {
-        return (value << magnitude) | (value >> sizeof (value) * 8 - magnitude);
+        return (value << magnitude) | (value >> (sizeof (value) * 8 - magnitude));
     }
 
 
@@ -47,7 +47,7 @@ namespace util {
     constexpr T
     rotater [[gnu::pure]] (const T value, std::size_t magnitude)
     {
-        return (value >> magnitude) | (value << sizeof (value) * 8 - magnitude);
+        return (value >> magnitude) | (value << (sizeof (value) * 8 - magnitude));
     }
 
 

fixed.cpp

@@ -145,7 +145,7 @@ template <typename T, unsigned I, unsigned E>               \
 fixed<T,I,E>                                                \
 fixed<T,I,E>::operator OP (integer_type val) const          \
 {                                                           \
-    return fixed<T,I,E>::from_native (m_value OP val << E); \
+    return fixed<T,I,E>::from_native (m_value OP (native_type{val} << E)); \
 }
 
 SIMPLE_INTEGER_LIT(+)

fixed.hpp

@@ -24,7 +24,15 @@
 #include <iosfwd>
 
 namespace util {
-    template <typename T, unsigned I, unsigned E>
+    template <
+        // whether the type is signed or unsigned. supply an appropriately
+        // signed type here; it won't be used for anything else.
+        typename T,
+        // how many bits total are used for the integral component
+        unsigned I,
+        // how many bits are used for the fractional component
+        unsigned E
+    >
     class [[gnu::packed]] fixed {
     public:
         static_assert (I > 0);

json2/personality/jsonish.cpp

@@ -76,9 +76,9 @@ jsonish::parse_number (const std::function<callback_t> &cb,
             ++cursor;
 
             auto digit_start = cursor;
-            while (cursor != last && ('0' <= *cursor && *cursor <= '9' ||
+            while (cursor != last && ((('0' <= *cursor) && (*cursor <= '9')) ||
-                                      'a' <= *cursor && *cursor <= 'f' ||
+                                      (('a' <= *cursor) && (*cursor <= 'f')) ||
-                                      'A' <= *cursor && *cursor <= 'F'))
+                                      (('A' <= *cursor) && (*cursor <= 'F'))))
                 ++cursor;
             if (digit_start == cursor)
                 throw parse_error {cursor};

maths.hpp

@@ -425,7 +425,7 @@ namespace util {
     bool
     samesign (T a, T b)
     {
-        return a < 0 && b < 0 || a > 0 && b > 0;
+        return (a >= 0 && b >= 0) || (a <= 0 && b <= 0);
     }