nerdcruft/libcruft-util
1
0
Fork 0
Code Issues Releases Activity

maths: use mult rather than negation in constexpr

Browse Source 
util::digits was triggering signed overflow warnings under gcc. By using
negative multiplication rather than explicit negation we get the same
behaviour, sans warning.
This commit is contained in:
Danny Robson 2016-08-29 14:48:07 +10:00
parent 98c09df7f9
commit 3d5aff0f30
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
maths.hpp
View File

@ -312,7 +312,7 @@ namespace util {
digits (ValueT value, BaseT base) noexcept digits (ValueT value, BaseT base) noexcept
{ {
if (value < 0) if (value < 0)
return digits (-value, base); value *= -1;
unsigned tally = 1; unsigned tally = 1;
while (value /= base) while (value /= base)