nerdcruft/libcruft-util
1
0
Fork 0
Code Issues Releases Activity

parallel/queue: add nodiscard to push/pop

Browse Source 
Users _must_ check the return value otherwise they've no indication
whether anything happened... This is a pretty common mistake because it
looks a lot like a typical push/pop operation.
This commit is contained in:
Danny Robson 2018-03-22 14:57:34 +11:00
parent 4f4b812356
commit 3689b08535
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
parallel/queue.hpp
View File

@ -66,7 +66,7 @@ namespace util::parallel {
/// if updating the write pointer fails we bail and return false. /// if updating the write pointer fails we bail and return false.
/// else, we will be able to commit the data and return true. /// else, we will be able to commit the data and return true.
bool bool
push (const ValueT &val) push [[nodiscard]] (const ValueT &val)
{ {
do { do {
// find our current and next indices, checking there is // find our current and next indices, checking there is
@ -119,7 +119,7 @@ namespace util::parallel {
/// importantly: the contents of the provided reference may have been /// importantly: the contents of the provided reference may have been
/// overwritten, but should not be used unless true was returned. /// overwritten, but should not be used unless true was returned.
bool bool
pop (ValueT &out) pop [[nodiscard]] (ValueT &out)
{ {
do do
{ {