nerdcruft/libcruft-util
1
0
Fork 0
Code Issues Releases Activity

job/queue: don't use references for parameters

Browse Source 
references aren't trivial types. we should support them soon, but this
gets us up and running faster.
This commit is contained in:
Danny Robson 2017-07-04 14:18:45 +10:00
parent 320fe6c378
commit 21f462d4a0
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
job/queue.hpp
View File

@ -93,6 +93,7 @@ namespace util::job {
} while (!done.load ()); } while (!done.load ());
} }
private: private:
/// stores a functor and associated arguments in a fixed size buffer /// stores a functor and associated arguments in a fixed size buffer
/// for later execution. /// for later execution.
@ -112,8 +113,8 @@ namespace util::job {
template <class Function, typename ...Args> template <class Function, typename ...Args>
args (Function &&func, Args&&...params) args (Function &&func, Args&&...params)
{ {
using tuple_t = std::tuple<Args...>; using tuple_t = std::tuple<std::decay_t<Args>...>;
static_assert ((std::is_trivial_v<decltype(params)> && ...)); static_assert ((std::is_trivial_v<std::decay_t<decltype(params)>> && ...));
static_assert (sizeof (tuple_t) <= sizeof data); static_assert (sizeof (tuple_t) <= sizeof data);
union { union {
@ -121,7 +122,7 @@ namespace util::job {
tuple_t *args_ptr; tuple_t *args_ptr;
}; };
byte_ptr = &data; byte_ptr = &data;
*args_ptr = std::make_tuple (std::forward (params)...); *args_ptr = std::make_tuple (params...);
function = [func] (args &base) { function = [func] (args &base) {
std::apply (func, *reinterpret_cast<tuple_t*> (&base.data)); std::apply (func, *reinterpret_cast<tuple_t*> (&base.data));