From 66de6a75c0ee8f8df2840879522d0aee6d34e2b1 Mon Sep 17 00:00:00 2001 From: Danny Robson Date: Fri, 1 Nov 2019 11:11:37 +1100 Subject: [PATCH 5/7] Disable the pseudo-build ID generation for PECOFF It should be clearer when the build-id isn't picked up. Using zeros is far easier to detect than failing down to a faked ID. --- src/common/pecoff/pecoff_file_id.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/pecoff/pecoff_file_id.cc b/src/common/pecoff/pecoff_file_id.cc index a8a9c2f5..04563c86 100644 --- a/src/common/pecoff/pecoff_file_id.cc +++ b/src/common/pecoff/pecoff_file_id.cc @@ -74,7 +74,7 @@ bool PeCoffFileID::PeCoffFileIdentifierFromMappedFile(const void* base, age)) return true; -#if 0 +#if 1 // XXX: Fallback to a default debug_identifier. memset(identifier, 0, kMDGUIDSize); *age = 0; -- 2.28.0